ZA2 Patou Mabando / HTML-CSS-Module-Project#367
Conversation
I added HTML and CSS to this file using flexbox CSS
PatouMabando
changed the title
PatouMabando
changed the title
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
| <header> | ||
| <div class="header container"> |
There was a problem hiding this comment.
This div with the class header container is not looking good, however, your header must a least have 2 child elements, the logo, and the nav list, organizing it this way will make your CSS much clear.
There was a problem hiding this comment.
Can You please suggest to me how I can write it down please. Thanks
| <figcaption>Pay as You Go</figcaption> | ||
| </figure> | ||
|
|
||
| </ul> |
There was a problem hiding this comment.
Writing your ul inside your figure tag would be much better than keeping it outside the figure, please re-organize your HTML structure in this area,
There was a problem hiding this comment.
Can You please suggest to me how I can write it down please. Thanks
Mathias02
left a comment
Mathias02
left a comment
There was a problem hiding this comment.
Patou, would you please review my Karma project and suggest changes in the pull request
All the the wrong tag in my HTML on top are removed. Thank you Mathias, I did pay attention on that mistake.
PatouMabando
left a comment
PatouMabando
left a comment
There was a problem hiding this comment.
Thank Mathias.
I removed all the wrong tag in HTML file.
For your last two suggestion, can you please suggest to me how I can write it down please. Thanks
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
| <header> | ||
| <div class="header container"> |
There was a problem hiding this comment.
Can You please suggest to me how I can write it down please. Thanks
| <figcaption>Pay as You Go</figcaption> | ||
| </figure> | ||
|
|
||
| </ul> |
There was a problem hiding this comment.
Can You please suggest to me how I can write it down please. Thanks
I update the images link.
I add the background image link in Hero-container CSS
2 participants
I added HTML and CSS to this file using flexbox CSS
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details HTML-CSS-Module-Project
Notes
What did you find easy? The Layout
What did you find hard?
What do you still not understand?
Any other notes?